Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SESSION_COOKIE_SECURE to production docs #457

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

jacobtylerwalls
Copy link
Member

brief description of changes

We didn't have explicit guidance around this setting before, but it was warned about by manage.py check --deploy path.to.production.settings, which we recently added to the upgrade instructions in 7.6.0.md for extra visibility, even though we also link to the the django deployment checklist here in this document, which advises the same action).

Do we want to describe the other action items that users are likely going to need to care about after they see the output of manage.py check --deploy?

@aarongundel
Copy link
Contributor

That is a good idea @jacobtylerwalls - if it comes up in the check, we should probably document that or at least link to supporting documentation in django.

@jacobtylerwalls
Copy link
Member Author

Thanks for the review. I'll merge this but will open a follow-up ticket to consider reimagining this page to guide people to manage.py check --deploy

Copy link
Collaborator

@ekansa ekansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is very helpful and the security implications are well explained.

@ekansa ekansa merged commit 6840ba7 into master Aug 19, 2024
@jacobtylerwalls jacobtylerwalls deleted the security/session-cookie branch August 19, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants