Show the application name in the splash screen #6531 #11661
Conversation
Currently, the splash screen does not show the application name. It shows "Arches" in all cases. This commit adds the application name to the splash screen. Changed the nav bar to show and the carousel to show the application name.
MikeGriniezakis
force-pushed
the
6531_splash_page_application_name
branch
from
1f90b9e to
f71e3d0
Compare
There was a problem hiding this comment.
Thanks for submitting this @MikeGriniezakis. It seems that the project settings aren't being used in the index view in main.py, but rather the Arches settings, so that will need to be fixed to get this working.
The template changes would also need to be made to the project template so that they are reflected in new projects. You can find that here: arches/arches/install/arches-templates/project_name/templates/index.htm.
arches/app/views/main.py
Outdated
| @@ -34,6 +34,7 @@ def index(request): | |||
| "main_script": "index", | |||
| "active_page": "Home", | |||
| "app_title": settings.APP_TITLE, | |||
| "app_name": settings.APP_NAME, | |||
There was a problem hiding this comment.
This doesn't seem to use the project settings, but rather only the Arches settings, so this value remains 'Arches'.
There was a problem hiding this comment.
I updated the code to use the project settings when getting the APP_NAME in the commit d57bf02
There was a problem hiding this comment.
Isn't "Arches" the expected value if there has not been a system settings tile saved for this setting?
There was a problem hiding this comment.
Upon running the setup_db, the value "Arches" is inserted as the default value into the Application Name setting. With my previous commit, the splash page only changes when the Application Name is changed through the settings.
| from urllib.parse import urlparse | ||
|
|
||
| from django.conf import settings as project_settings |
There was a problem hiding this comment.
Actually, I don't think we should be importing settings via the standard Django import until we address the behavior difference between dev and prod fleshed out in #11660.
arches/app/views/main.py
Outdated
| @@ -34,6 +34,7 @@ def index(request): | |||
| "main_script": "index", | |||
| "active_page": "Home", | |||
| "app_title": settings.APP_TITLE, | |||
| "app_name": settings.APP_NAME, | |||
There was a problem hiding this comment.
Isn't "Arches" the expected value if there has not been a system settings tile saved for this setting?
|
Hi @MikeGriniezakis - I really appreciate your work on this. Your effort has been really valuable in exposing the importance of addressing #11660 as @jacobtylerwalls has pointed out. In light of this fact, and the fact that the index page is something that generally gets overwritten during project development anyhow, I don't think we should invest more time in this, so I'm going to close this PR and issue. Again, thanks very much for your help. |
Types of changes
Description of Change
The Application Name setting was not taken into account when rendering the splash screen.
This PR changes the default "Arches" text to use the Application Name setting.
Issues Solved
Closes #6531
Checklist
Ticket Background