-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11670 Make webpack add filehashes to all (read: entrypoint) js files in build #11724
Open
whatisgalen
wants to merge
14
commits into
dev/8.0.x
Choose a base branch
from
11670_hashed_files
base: dev/8.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 45947d2. revert
…nto archesproject-dev/8.0.x pulls latest from head
whatisgalen
changed the title
11670 hashed files
11670 Make webpack add filehashes to all js files in build
Jan 10, 2025
|
whatisgalen
changed the title
11670 Make webpack add filehashes to all js files in build
11670 Make webpack add filehashes to all (read: entrypoint) js files in build
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
This PR creates a webpack_manifest (essentially just a lookup for files to their actual webpack asset filename) so that all
.js
files can be saved using a filehash in the filename, thereby forcing a cache burst on end-user browser clients whenever novel changes get pushed to a deployment. This is effective on both dev and prod builds.The
base.py
view now looks up the asset corresponding to themain_script
value.See webpack-manifest-plugin for more docs
Note that there is an assumption in where the manifest should be looked for:
...and it's possible this should search a list of locations instead.
Issues Solved
Closes #11670
Testing this PR
You will need to add:
to your project dependencies and run
npm install
to install webpack_manifest. You'll also want to run both a production and development build of webpack. All "main_views" should be tested, e.g.Checklist
Accessibility Checklist
Developer Guide
Ticket Background
Further comments