Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PlugCrypto binary to term in bootstrap.info #1180

Merged
merged 2 commits into from
Jul 25, 2023
Merged

use PlugCrypto binary to term in bootstrap.info #1180

merged 2 commits into from
Jul 25, 2023

Conversation

apoorv-2204
Copy link
Contributor

though its not user-data , but still.

Copy link
Member

@bchamagne bchamagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this, maybe we can add a Credo rules to forbid the usage of binary_to_term alltogether (and use this function instead).

@apoorv-2204
Copy link
Contributor Author

apoorv-2204 commented Jul 20, 2023

maybe we can add a Credo rules to forbid

Credo do has high priority warning i.e for binary_to_term and it does report, but as of now we are just ignoring it, so it dont crash cicd

@Neylix
Copy link
Member

Neylix commented Jul 21, 2023

If there is configuration that ignore this check, we should not ignore it. Could you update the conf to ensure credo raise a warning if there is a binary to term used ?

@apoorv-2204
Copy link
Contributor Author

If there is configuration that ignore this check, we should not ignore it. Could you update the conf to ensure credo raise a warning if there is a binary to term used ?

There are also other critical issues reported by credo, aka priority high . Exiting the credo at priority high will eventually crash as they are not fixed yet

@Neylix
Copy link
Member

Neylix commented Jul 24, 2023

If there is configuration that ignore this check, we should not ignore it. Could you update the conf to ensure credo raise a warning if there is a binary to term used ?

There are also other critical issues reported by credo, aka priority high . Exiting the credo at priority high will eventually crash as they are not fixed yet

Do you mean Credo or Sobelow ?

@apoorv-2204
Copy link
Contributor Author

If there is configuration that ignore this check, we should not ignore it. Could you update the conf to ensure credo raise a warning if there is a binary to term used ?

There are also other critical issues reported by credo, aka priority high . Exiting the credo at priority high will eventually crash as they are not fixed yet

Do you mean Credo or Sobelow ?

credo

@Neylix Neylix added the quality Improve code quality label Jul 25, 2023
@Neylix Neylix merged commit 58ec8b7 into archethic-foundation:develop Jul 25, 2023
1 check passed
Neylix pushed a commit to Neylix/archethic-node that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Improve code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants