-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use PlugCrypto binary to term in bootstrap.info #1180
use PlugCrypto binary to term in bootstrap.info #1180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this, maybe we can add a Credo rules to forbid the usage of binary_to_term
alltogether (and use this function instead).
Credo do has high priority warning i.e for binary_to_term and it does report, but as of now we are just ignoring it, so it dont crash cicd |
If there is configuration that ignore this check, we should not ignore it. Could you update the conf to ensure credo raise a warning if there is a binary to term used ? |
There are also other critical issues reported by credo, aka priority high . Exiting the credo at priority high will eventually crash as they are not fixed yet |
Do you mean Credo or Sobelow ? |
credo |
though its not user-data , but still.