Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mining: check for unknown origin as part of the valid pending transaction #1557

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bchamagne
Copy link
Member

Description

Differentiate an invalid proof of work from an unknown origin.
Fixes #1539

Type of change

  • Improvment

How Has This Been Tested?

I modified the CLI to send invalid origin signature. Then I sent a transaction with the CLI
Capture d’écran 2024-08-26 à 16 50 51

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added mining Involve transaction validation and mining quality Improve code quality labels Aug 26, 2024
@bchamagne bchamagne marked this pull request as draft August 26, 2024 15:20
@bchamagne bchamagne marked this pull request as ready for review August 27, 2024 14:18
lib/archethic/mining/validation_context.ex Outdated Show resolved Hide resolved
lib/archethic/mining/pending_transaction_validation.ex Outdated Show resolved Hide resolved
lib/archethic/mining/validation_context.ex Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mining Involve transaction validation and mining quality Improve code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect handling of not found proof of work
2 participants