Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume inputs even if not genesis node #1574

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 15, 2024

Description

Currently when a node is not genesis node of a transaction, it does not consume or update the UTXO of the genesis address of the chain.
But in some case, it is possible that a node is genesis node for a chain and store its UTXO, then the election change and it is not genesis node anymore but still store some transaction of the chain as storage node.
Then is become genesis node again, but since it already stored the transaction of this chain it will node re ingest the transaction and consume the inputs. So we encounter an issue where a the node keeps already spent UTXO in its view.

To fix it, even if the node is not genesis node of a chain, it consume the inputs and update the utxo of the genesis.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working replication labels Oct 15, 2024
@Neylix Neylix merged commit 389b785 into archethic-foundation:develop Oct 22, 2024
2 checks passed
@Neylix Neylix deleted the Fix-non-spent-utxo branch October 22, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working replication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants