Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort ownership authorized keys in serialization #1575

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 15, 2024

Description

To ensure serialization of the ownership is the same between node and sdk, ownership's authoized key map is sorted as done by sdk.
This will not be the case by default when upgrading to erlang 26

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added serialization Involve message serialization enhancements labels Oct 15, 2024
@Neylix Neylix merged commit bcd6e95 into archethic-foundation:develop Oct 22, 2024
2 checks passed
@Neylix Neylix deleted the Sort-authorized-keys branch October 22, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements serialization Involve message serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants