Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the acceptance_resolver more often #1582

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

bchamagne
Copy link
Member

Description

There are cases where we know for sure that we are querying data that exists, in these cases we add an acceptance_resolver to keep asking the data until we find it.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

unit test on the transaction_context

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added the P2P Involve P2P networking label Oct 22, 2024
use it in the replication when we are sure the previous transaction exists
@Neylix Neylix merged commit e8404f7 into archethic-foundation:develop Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2P Involve P2P networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants