Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the genesis address in the validation_stamp #1588

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bchamagne
Copy link
Member

@bchamagne bchamagne commented Nov 4, 2024

Description

Added the genesis_address in the validation_stamp. It's written on disk only on IO transaction, because the chain storage is written in a file named by the genesis, so there's no point to duplicate the data there.
There's a migration script to run on all legacy IOs

  • Update migration version when decided which version it'll be

Fixes #1562

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Updated the code to store every tx also as IO then run a release upgrade on 4 nodes.
Chain & IO storage both returned the genesis address on legacy and new transactions

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added the transaction Involve transactions label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transaction Involve transactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add genesis address in Validation Stamp
1 participant