Webpack not compatible with require aliases

[tomas-polach]

How to Reproduce

• clone https://github.com/facebook/create-react-app
• create a new app
• install using npm install [email protected]
• build app

Actual Result

• webpack complains about require aliases runtime.require (WIP, precise error message follows)

Expected Result

• app builds without problem

Note

• require aliases runtime.require are needed in react native context. Details: 3dio.js can't be bundled with React Native because of dynamic requires #89

[bnjm]

I've been doing some digging into this. It seems webpack spots the require reference and tries to parse it. The same error will occur if you call console.log(require), console.log(typeof require) etc. I could reproduce this with a few of the popular webpack templates (https://github.com/facebook/create-react-app and http://vuejs-templates.github.io/webpack/).

Unfortunately this means this means that the current build (1.1.7) is still affected since it includes the getDynamicRequire function which will throw an error to webpack.

I think we can work around this with global.require, but I need to test it... PR incoming

[bnjm]

Just ran some tests and can confirm that this PR fixes the issue for model-maker #127

[bnjm]

Reopening because this is an issue again in 1.1.8

[kashi-halma]

I am having this exact same issue with 1.1.8. Any recommendations?

[kashi-halma]

Please, someone help!

[bnjm]

Thanks for bumping this, I would suggest using 1.1.5 with webpack until it's resolved.

[kashi-halma]

bnjm,

Thank you so much for responding. Regardless of what version of the 3dio npm module I use I still get the following error.

[bnjm]

I can't reproduce this with 1.1.5 starting with a fresh wepback + react app and using yarn add [email protected] or npm install [email protected].

If you have a package lock file could you check the output just to make sure 1.1.5 is being installed? If the problem is still occurring with 1.1.5 please let me know as that's a separate issue.

We'll aim to ship a fix for this on Monday. Thanks for your patience!

[kashi-halma]

Thanks again bnjm!

-from the blockvue dev team

[bnjm]

hey @bleudreams, there is a PR submitted to resolve this issue: #135, we'll make another release soon to include it!

[bnjm]

This is fixed in 1.2.0 which is available now.

@bleudreams Let us know if you still have any problems with this!

[kashi-halma]

Benjamin, Thank you so much for the reply. I really appreciate. KRH

…

On Wednesday, May 2, 2018, Benjamin Devine ***@***.***> wrote: This is fixed in 1.2.0 which is available now. @bleudreams <https://github.com/bleudreams> Let us know if you still have any problems with this! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#126 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aa41h_2UQFdz59N4B2GQGKrFJykn0C7bks5tuZ_cgaJpZM4SG-mg> .