This repository has been archived by the owner on Oct 19, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Features
This PR removes the
require
alias's which were introduced as a work-around for the metro bundler, used by React Native, which does not support dynamicrequire
statements as they were used in 3dio-js.Webpack doesn't allow for any references to
require
which are not being used for import purposes..leading to the webpack errorcannot find module "."
: #126We attempted to get around this by accessing
require
asglobal.require
however this caused some issues in node.js.Design
Reverts back to using
require
as it should be :)How to test
Webpack:
Browser & node.js:
Check that the samples in the examples folder are running.
Notes
This will cause an incompatibility for React Native + 3dio.js. I will update my RN compatible fork at https://github.com/bnjm/3dio-js incase there are any affected users.