This repository has been archived by the owner on Oct 19, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 73
Add support for react native environment #125
Merged
tomas-polach
merged 21 commits into
archilogic-com:master
from
bnjm:dynamic-require-alias
Feb 15, 2018
Merged
Add support for react native environment #125
tomas-polach
merged 21 commits into
archilogic-com:master
from
bnjm:dynamic-require-alias
Feb 15, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic require fix
use requireAlias for form-data
merge with master merge with master merge with master
bnjm
force-pushed
the
dynamic-require-alias
branch
from
February 13, 2018 09:53
941b59c
to
f35c9d4
Compare
Attached issue: #89 |
tomas-polach
approved these changes
Feb 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! good to go from my side
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Features
Design
require
calls can be made from node and react native environments asio3d.runtime.require('../module')
How to use
How to test
have to also include the mock require like shown in the file
Notes
Edit: There are few unnecessary commits here as this was built off an earlier experiment in my fork, happy to squash these where possible.