Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use coverlet code coverage #396

Merged

Conversation

stijnmoreels
Copy link
Member

Use Coverlet code coverage as GitHub action.

Relates to arcus-azure/arcus#264

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for arcus-security canceled.

Name Link
🔨 Latest commit 691dd83
🔍 Latest deploy log https://app.netlify.com/sites/arcus-security/deploys/63c5238c6e6f2900080fbacd

@stijnmoreels stijnmoreels self-assigned this Jan 13, 2023
@stijnmoreels stijnmoreels changed the title chore: use coverlet code coverage chore: use coverlet code coverage (🏗👷‍♂️) Jan 13, 2023
@stijnmoreels stijnmoreels changed the title chore: use coverlet code coverage (🏗👷‍♂️) chore: use coverlet code coverage Jan 16, 2023
Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job extending the test-suite based on the coverage results. (Although it could've been done in a separate PR).

.github/workflows/code-coverage.yml Show resolved Hide resolved
@fgheysels fgheysels merged commit 8c0ccaa into arcus-azure:main Jan 16, 2023
@stijnmoreels
Copy link
Member Author

Good job extending the test-suite based on the coverage results. (Although it could've been done in a separate PR).

Excluded the test functionality and the provider projects as this last one is mostly integration stuff towards other environments (i.e. Azure Key Vault, HashiCorp Vault...) and these are tested in integration tests.

@stijnmoreels stijnmoreels deleted the chore/use-coverlet-code-coverage branch January 16, 2023 11:15
@stijnmoreels
Copy link
Member Author

Good job extending the test-suite based on the coverage results. (Although it could've been done in a separate PR).

Could be in a diff PR, but I added 80% as a threshold to be above, and wanted to be above that here. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants