Merge pull request #202 from ardalis/kylemcmaster/fix-tests

General fixes and maintenance
ardalis · Dec 14, 2023 · b21b06e · b21b06e
2 parents 6987b91 + eb20037
commit b21b06e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -80,6 +80,11 @@ dotnet_style_prefer_compound_assignment = true:suggestion
 dotnet_style_prefer_simplified_interpolation = true:suggestion
 dotnet_style_namespace_match_folder = true:suggestion
 ###############################
+# IDE EditorConfig Settings   #
+###############################
+# IDE0005: Using directive is unnecessary.
+dotnet_diagnostic.IDE0005.severity = warning
+###############################
 # C# Coding Conventions       #
 ###############################
 [*.cs]

diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -16,13 +16,8 @@
     <PackageVersion Include="Autofac" Version="6.4.0" />
     <PackageVersion Include="Autofac.Extensions.DependencyInjection" Version="8.0.0" />
     <PackageVersion Include="coverlet.collector" Version="6.0.0" />
-    <PackageVersion Include="FastEndpoints" Version="5.3.2" />
-    <PackageVersion Include="FastEndpoints.ApiExplorer" Version="2.0.1" />
-    <PackageVersion Include="FastEndpoints.Swagger" Version="5.2.1" />
-    <PackageVersion Include="FastEndpoints.Swagger.Swashbuckle" Version="2.0.1" />
     <PackageVersion Include="MediatR" Version="11.0.0" />
     <PackageVersion Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="8.0.0" />
-    <PackageVersion Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="7.0.0" />
     <PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="7.0.0" />
     <PackageVersion Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.0" />
     <PackageVersion Include="Microsoft.EntityFrameworkCore.InMemory" Version="7.0.0" />
@@ -36,10 +31,8 @@
     <PackageVersion Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.19.5" />
     <PackageVersion Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="7.0.0" />
     <PackageVersion Include="Moq" Version="4.18.4" />
-    <PackageVersion Include="Newtonsoft.Json" Version="13.0.2-beta2" />
     <PackageVersion Include="ReportGenerator" Version="5.1.12" />
     <PackageVersion Include="Serilog.AspNetCore" Version="6.1.0-dev-00285" />
-    <PackageVersion Include="Serilog.Sinks.ApplicationInsights" Version="4.0.1-dev-00040" />
     <PackageVersion Include="SQLite" Version="3.13.0" />
     <PackageVersion Include="Swashbuckle.AspNetCore" Version="6.4.0" />
     <PackageVersion Include="Swashbuckle.AspNetCore.Annotations" Version="6.4.0" />

diff --git a/src/CleanArchitecture.Core/Services/EntryPointService.cs b/src/CleanArchitecture.Core/Services/EntryPointService.cs
@@ -28,7 +28,7 @@ public async Task ExecuteAsync()
 
       // read from the queue
       string message = await _queueReceiver.GetMessageFromQueue(_settings.ReceivingQueueName);
-      if (String.IsNullOrEmpty(message)) return;
+      if (string.IsNullOrEmpty(message)) return;
 
       // check 1 URL in the message
       var statusHistory = await _urlStatusChecker.CheckUrlAsync(message, "");

diff --git a/tests/CleanArchitecture.UnitTests/Core/EntryPointServiceExecuteAsync.cs b/tests/CleanArchitecture.UnitTests/Core/EntryPointServiceExecuteAsync.cs
@@ -20,11 +20,12 @@ private static (EntryPointService, Mock<ILoggerAdapter<EntryPointService>>, Mock
     };
     var queueReceiver = new Mock<IQueueReceiver>();
     var serviceLocator = new Mock<IServiceLocator>();
+    var urlStatusChecker = new Mock<IUrlStatusChecker>();
 
     // maybe a tuple later on
     var repository = SetupCreateScope(serviceLocator);
 
-    var service = new EntryPointService(logger.Object, settings, queueReceiver.Object, null, serviceLocator.Object, null);
+    var service = new EntryPointService(logger.Object, settings, queueReceiver.Object, serviceLocator.Object, urlStatusChecker.Object);
     return (service, logger, queueReceiver, serviceLocator, repository);
   }