Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make globalGqlIdentifierName case sensitive #5945

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fantastiskm
Copy link

@fantastiskm fantastiskm commented Feb 29, 2024

Description

Currently globalGqlIdentifierNames are converted to lower case before being used for matching. This patch removes this conversion so they match in the file if the identifier in the code source is not all lower case. Previously if you had a mixed case globalGqlIdentifierName in the source code it would not match.

Eg: const x = testGql( could not be plucked using globalGqlIdentifierName as it is mixed case.

It also re-enables tests

Related # 5944

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • unit test
  • used in own project

Test Environment:

  • OS: MacOS
  • @graphql-tools/...: master
  • NodeJS: 18

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

fantastiskm and others added 3 commits February 29, 2024 09:25
Global identifiers are converted to lower case before being used in this file. This patch corrects the comparison function to so they match in the file if the source identifier is not all lower case
Copy link

changeset-bot bot commented Feb 29, 2024

⚠️ No Changeset found

Latest commit: 5402604

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ardatan
Copy link
Owner

ardatan commented Feb 29, 2024

Why would we make it case insensitive?
Why don't we solve the issue directly? If identifier name is lowercased in somewhere, let's remove that instead.

- don't lower case any globalGqlIdentifierNames
@fantastiskm
Copy link
Author

Totally works for me especially as identifiers are normally case sensitive. I just didn't want to break existing code ;) I've updated the branch

@fantastiskm fantastiskm changed the title make globalGqlIdentifierName case insensitive make globalGqlIdentifierName case sensitive Mar 2, 2024
@ardatan ardatan force-pushed the master branch 5 times, most recently from d34fb65 to b8bf584 Compare August 11, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants