Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(load-files): generic for loadFilesSync and loadFiles #6503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjangga0214
Copy link

@jjangga0214 jjangga0214 commented Sep 9, 2024

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

  • loadFilesSync has generic while loadFiles. So generic is added to loadFiles.
  • Instead of <T = any>, <T = DocumentNode> is used, since they are mainly used for loading schema. This even makes it work with graphql-module.
import { createModule } from 'graphql-modules'

export default createModule({
  // `typeDefs` requires `DocumentNode[]`. 
  // Before, `loadFiles` caused type error as it's `any[]`. 
  // But by this PR, it works as expected.
  typeDefs: await loadFiles('...'),
})

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [?] Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Sep 9, 2024

⚠️ No Changeset found

Latest commit: ac3a011

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jjangga0214 jjangga0214 changed the title build(types): generic for loadFilesSync and loadFiles build(load-files): generic for loadFilesSync and loadFiles Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant