Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always initialize timeout value #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Always initialize timeout value #9

wants to merge 3 commits into from

Conversation

sandeepmistry
Copy link

Without this patch RestClient(Client& netClient, const char* _host) was the only constructor to initialize this->timeout, so if RestClient(Client& netClient, const char* _host, int _port) was used it would have a timeout of 0 causing issues like #7.

This patch:

  • reduces duplication in the constructors, ensures timeout is always set (resolves Status = 0 unless delay is increased #7)
  • bumps the default timeout to 10s (previous was 1s)
  • removes an unnecessary delay in the library

cc/ @tigoe @don

@sandeepmistry sandeepmistry mentioned this pull request Apr 6, 2016
Open
@LucaCerina
Copy link

+1 on this pull-request, I encountered the same exact problem.
Why it didn't got accepted in 2 years?

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Status = 0 unless delay is increased
3 participants
@sandeepmistry @LucaCerina @CLAassistant