Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "pimp" from registry.txt #3210

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Remove "pimp" from registry.txt #3210

merged 1 commit into from
Aug 14, 2023

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 11, 2023

Rather than following the standard procedure for name and URL change, the library was resubmitted under the new URL+name (#3196). This pull request removes the previous registration from the list.

Even though the conditions that triggered this operation are unusual here in the registry, it is a standard removal operation for the "backend maintainer".

Companion to #3209
Resolves #3195

@per1234 per1234 added topic: removal Remove library from the list status: pending backend Depends on backend maintenance operations labels Aug 11, 2023
@MatteoPologruto MatteoPologruto self-assigned this Aug 14, 2023
MatteoPologruto
MatteoPologruto approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2023/08/14 09:11:43 Loaded 6084 libraries from DB
Removing pimp
Success!

@MatteoPologruto MatteoPologruto merged commit 487fe94 into arduino:production Aug 14, 2023
2 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Aug 14, 2023
@per1234 per1234 deleted the remove-pimp-registry branch August 17, 2023 07:58
@per1234 per1234 removed the status: pending backend Depends on backend maintenance operations label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

Assignees

@MatteoPologruto MatteoPologruto

Labels
conclusion: resolved Issue was resolved topic: removal Remove library from the list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@per1234 @MatteoPologruto