Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL of "JBLogger" #3563

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Nov 5, 2023

No description provided.

@github-actions github-actions bot added the topic: modification Change existing list entry label Nov 5, 2023
Copy link
Contributor

github-actions bot commented Nov 5, 2023

Hi @per1234.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

github-actions bot commented Nov 5, 2023

ERROR: Arduino Lint found errors with https://github.com/jonnybergdahl/Arduino_JBLogger_Library:

Linting library in Arduino_JBLogger_Library
INFO: No header file found matching library name (JBLogger.h). Best practices are for primary header filename to match  
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name JBLogger not found in the Library Manager index. Library names are not allowed to change after being
       added to the index.                                                                                              
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in Arduino_JBLogger_Library/examples/LoggingExample

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

Copy link
Contributor

github-actions bot commented Nov 5, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @per1234
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Nov 5, 2023
Copy link
Contributor Author

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR: Library name JBLogger not found in the Library Manager index. Library names are not allowed to change after being
       added to the index.                                                                                              
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)

This error is expected and will be resolved by #3564

@MatteoPologruto MatteoPologruto self-assigned this Nov 8, 2023
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2023/11/08 14:48:48 Loaded 6352 libraries from DB
Removing Bergdahl_JBLogger
Success!

@MatteoPologruto MatteoPologruto merged commit f166193 into arduino:main Nov 8, 2023
12 checks passed
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Nov 8, 2023
@per1234 per1234 deleted the move-JBLogger branch November 9, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: modification Change existing list entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants