Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/emissive #63

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Feat/emissive #63

merged 4 commits into from
Jan 22, 2025

Conversation

piellardj
Copy link
Member

This PR adds support for emissive materials.

interface IVoxelMaterial {
    readonly color: Color;
    readonly shininess?: number;
    readonly emissiveness?: number;
}

There is one restriction: a material cannot be both specular and emissive.

@piellardj piellardj requested a review from Sceat January 19, 2025 16:35
@piellardj piellardj self-assigned this Jan 19, 2025
@Sceat
Copy link
Member

Sceat commented Jan 22, 2025

/merge

@github-actions GitHub Actions
Copy link

Success! Fast forwarded master to feat/emissive! git checkout master && git merge feat/emissive --ff-only

@github-actions github-actions bot merged commit c1355e1 into master Jan 22, 2025
2 checks passed
@Sceat Sceat deleted the feat/emissive branch January 22, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sceat Sceat Sceat approved these changes

Assignees

@piellardj piellardj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piellardj @Sceat