Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .circleci/config.yml #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add .circleci/config.yml #101

wants to merge 2 commits into from

Conversation

samgdotson
Copy link
Collaborator

@samgdotson samgdotson commented Nov 4, 2020 •
edited
Loading

This PR adds CircleCI to pride. Before this branch can be merged there are some issues that need to be fixed.

#100 Tests are failing

The config.yml file still needs to be fixed. It currently cannot clone temoa (the folder to clone into is broken).

Once successful, this PR will close #72

@samgdotson samgdotson added Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:2-Normal This work is important and should be completed ASAP. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Test Is related to software testing. Failing tests, necessary new tests, test frameworks, etc. labels Nov 4, 2020
@samgdotson samgdotson self-assigned this Nov 4, 2020
@samgdotson
Copy link
Collaborator Author

The docker image probably needs to be some version of anaconda/miniconda to run conda commands.

@robfairh
Copy link
Contributor

I don't understand. If we merge this, will it continue to fail unless we fix #100?

@samgdotson
Copy link
Collaborator Author

Good question, I wasn't very clear about this. The eia.py issue has been solved, BUT this will still fail because Circle CI doesn't properly build the environment. I need to keep fiddling with the config file to get it to work. Once all checks pass, here, then you can merge. Thanks for reviewing!

@robfairh
Copy link
Contributor

Great! Consider making this a draft.

katyhuff
katyhuff reviewed May 22, 2024
View reviewed changes
Copy link
Member

@katyhuff katyhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samgdotson is this overcome by events? Perhaps this should be made a "draft" PR as Roberto suggested?

@samgdotson
Copy link
Collaborator Author

@katyhuff I think we can close this and archive the whole repository. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katyhuff katyhuff katyhuff left review comments

@gwenchee gwenchee Awaiting requested review from gwenchee

@robfairh robfairh Awaiting requested review from robfairh

At least 1 approving review is required to merge this pull request.

Assignees

@samgdotson samgdotson

Labels
Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:2-Normal This work is important and should be completed ASAP. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Test Is related to software testing. Failing tests, necessary new tests, test frameworks, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI
3 participants
@samgdotson @robfairh @katyhuff