Introduce ABIConstructor #196
Conversation
|
|
||
| return EthereumTransaction( | ||
| from: from, | ||
| to: EthereumAddress("0x"), |
| XCTAssertNoThrow(try encoder.encode("BokkyPooBah Test Token")) | ||
| XCTAssertNoThrow(try encoder.encode("BOKKY")) | ||
| XCTAssertNoThrow(try encoder.encode(UInt8(18))) |
There was a problem hiding this comment.
Tests also serve as examples, can we create a test-only type to conform to ABIConstructor protocol? Also helps testing from API point of view not internal code.
| XCTAssertNoThrow(try encoder.encode("BokkyPooBah Test Token")) | ||
| XCTAssertNoThrow(try encoder.encode("BOKKY")) | ||
| XCTAssertNoThrow(try encoder.encode(UInt8(18))) |
There was a problem hiding this comment.
Tests also serve as examples, can we create a test-only type to conform to ABIConstructor protocol? Also helps testing from API point of view not internal code.
| import Foundation | ||
| import BigInt | ||
|
|
||
| public class ABIConstructorEncoder { |
There was a problem hiding this comment.
Construction could be seen also as a special function call, so it makes sense from the types point of view.
I think we should leverage ABIFunctionEncoder which is already tested instead of duplicating code here.
Can create an enum in ABIFunctionEncoder with two cases:
enum EncodeVariant {
case call(name: String)
case construct(bytecode: Data)
}Then it's just a matter of changing encoded function to support both calls.
To keep API backwards compatible, we can still keep the same initializer with name which would just set the encoding type to call
|
@rinat-enikeev Thanks for the contribution, please see my comments above. This is a very nice feature to add to the library! |
|
|
||
| return EthereumTransaction( | ||
| from: from, | ||
| to: EthereumAddress("0x"), |
|
@rinat-enikeev are you going to update this? |
See issue.
Basically I want to be able to deploy contracts from Swift code.