Skip to content

Commit

Permalink
[BUGFIX] get dataset settings when using client.datasets.list() (#5810
Browse files Browse the repository at this point in the history
)

# Description
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->


**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->

- Bug fix (non-breaking change which fixes an issue)


**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->

**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->

- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
  • Loading branch information
frascuchon authored Feb 14, 2025
1 parent d413bd6 commit a9c80ec
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions argilla/src/argilla/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ def __call__(
warnings.warn(f"Dataset with name {name!r} not found in workspace {workspace.name!r}")

def __iter__(self):
return self._Iterator(self.list())
return self._Iterator([self._from_model(model) for model in self._api.list()])

@overload
@abstractmethod
Expand Down Expand Up @@ -389,7 +389,7 @@ def add(self, dataset: "Dataset") -> "Dataset":
return dataset

def list(self) -> List["Dataset"]:
return [self._from_model(model) for model in self._api.list()]
return list(self)

############################
# Private methods
Expand Down

0 comments on commit a9c80ec

Please sign in to comment.