Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): add poolclass config in SQLAlchemy engine for compatabilty with PgBouncer #5820

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Kop3sh
Copy link

@Kop3sh Kop3sh commented Mar 2, 2025

Description

  • add DEFAULT_DATABASE_POSTGRESQL_POOLING_ENABLED constant for easier toggling of SQLAlchemy connection pooling properties
  • configure server settings to provide NullPool in SQLAlchemy engine setup if pooling is disabled
  • add env configuration to k8s deployment files to match changes
  • update config doc files accordingly

Closes #5819

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Kop3sh added 3 commits March 2, 2025 12:04
…compatabilty with PgBouncer



- add DEFAULT_DATABASE_POSTGRESQL_POOLING_ENABLED constant for easier toggling of SQLAlchemy connection pooling properties
- configure server settings to provide NullPool in SQLAlchemy engine setup if pooling is disabled
- add postgres pooling environment configuration to k8s helm files
- update configuration doc files accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG-python/deployment] Server crashes when deployed with K8s and postgres (connection pooling issue)
1 participant