Exclude HF token from serialization #1129
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only
api_key
is being proactively excluded from dumps on any object.However, HF related objects, like
TransformersLLM
, definetoken
as a SecretStr: https://github.com/argilla-io/distilabel/blob/main/src/distilabel/models/llms/huggingface/transformers.py#L110That leads either to a failure to save:
Or a successful save:
That would produce a YAML file with:
That is unusable. And leads to a failure like:
A comment says like it should have been filtered automatically out since it is a SecretStr, however, nowhere can I use an encoder defined to do this.
So I went with the smallest change, just including the
token
into the exclusion list.