-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Argo CD CLI Admin Setting RBAC Can AppProject Roles Support (#11950) #19502
base: master
Are you sure you want to change the base?
feat: Argo CD CLI Admin Setting RBAC Can AppProject Roles Support (#11950) #19502
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
08e0e81
to
738d8c7
Compare
738d8c7
to
b8bbf64
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19502 +/- ##
==========================================
+ Coverage 55.18% 55.20% +0.01%
==========================================
Files 337 337
Lines 57058 57106 +48
==========================================
+ Hits 31487 31524 +37
- Misses 22875 22887 +12
+ Partials 2696 2695 -1 ☔ View full report in Codecov by Sentry. |
b8bbf64
to
ed4dbc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
Just had a minor question, nothing that would prevent this PR from merging. Please see below.
094e88a
to
dda392a
Compare
dda392a
to
cc59ac2
Compare
a4b5d3d
to
7297dd8
Compare
d64dbfd
to
61f5fe1
Compare
728a198
to
44cdcaa
Compare
Signed-off-by: Brian Dunnigan <[email protected]>
44cdcaa
to
b658818
Compare
Closes #11950
This PR updates the
argocd admin settings rbac can --namespace <namespace>
CLI command to include AppProject Roles in RBAC permissions checks involving Application Specific Policies.This PR does not support reading AppProject's from a file similar to how global policies may be loaded from a file with
--policy-file <policy-file>
instead of--namespace <namespace
. If there is interest in this, I would be open to updating the code to also support it.Checklist: