-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Clarify what the Force sync option does #20379
base: master
Are you sure you want to change the base?
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Please note: my initial suggestion here is not intended to be the end-result if we merge this PR. But I need to discuss this and get some input before I can improve the suggested change. |
The Thanks to #8574 we have a warning in the UI about doing force deletion which reads "The resources will be synced using '--force' that is a potentially destructive action and will immediately remove resources from the API and bypasses graceful deletion. Immediate deletion of some resources may result in inconsistency or data loss. Are you sure you want to continue?" Another relevant discussion on the topic is in #5172 |
Signed-off-by: Andreas Lindhé <[email protected]>
That's great, thank you for the details! I'll review the details in the links you sent and see if that can be incorporated into the docs. |
I would like some clarification on two details, before I know what to write:
I assume you mean
Does it really do delete and replace, even when And also: on all other items?? I tried running it, I don't think it seems like it touches any other resources than the one with annotation |
Signed-off-by: Andreas Lindhé <[email protected]>
Signed-off-by: Andreas Lindhé <[email protected]>
I've split the section in two now, to distinguish between |
This change attempts to clarify what exactly the Force sync option does.
I have a handful of issues with the current description:
--force
flag inkubectl
. If it does, then we should probably warn the user that there may be unintended consequences such as the pod being deleted from Kubernetes but the containers keep running on the node. If it does not, I think we should clarify that so users (like me) aren't too afraid to use it.Force=true
, only an example setting bothForce=true
andReplace=true
. Does it not make sense to use onlyForce=true
? I think it does! We should clarify the use-case for this.I opened a PR rather than discussing in an Issue first, because I think it's easier to reason about texts if we see the suggested change in front of us.
Checklist: