Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for app.Name if is empty, and pick the args[0] if so #20474 #20475

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

fix: handle the namespace/appname args[0]

8ebd966
Select commit
Loading
Failed to load commit list.
Open

fix: check for app.Name if is empty, and pick the args[0] if so #20474 #20475

fix: handle the namespace/appname args[0]
8ebd966
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 21, 2024 in 0s

55.04% (-0.04%) compared to ec499bb

View this Pull Request on Codecov

55.04% (-0.04%) compared to ec499bb

Details

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 55.04%. Comparing base (ec499bb) to head (8ebd966).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cmd/util/common.go 0.00% 13 Missing ⚠️
cmd/util/app.go 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20475      +/-   ##
==========================================
- Coverage   55.07%   55.04%   -0.04%     
==========================================
  Files         322      323       +1     
  Lines       54927    54948      +21     
==========================================
- Hits        30253    30244       -9     
- Misses      22068    22109      +41     
+ Partials     2606     2595      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov