-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config)!: exclude known interim resources by default (#20013) #21635
base: master
Are you sure you want to change the base?
feat(config)!: exclude known interim resources by default (#20013) #21635
Conversation
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21635 +/- ##
==========================================
- Coverage 55.59% 55.53% -0.07%
==========================================
Files 340 340
Lines 57419 57419
==========================================
- Hits 31924 31888 -36
- Misses 22807 22829 +22
- Partials 2688 2702 +14 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
…ve/argo-cd into exclude-default-resources
Signed-off-by: Alexandre Gaudreault <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @agaudreault!
Left 2 minor nit comments.
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, holding off merging in case you want to gather more feedback first
Pull request was converted to draft
Fixes #20013
Description