Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config)!: exclude known interim resources by default (#20013) #21635

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

agaudreault
Copy link
Member

@agaudreault agaudreault commented Jan 22, 2025

Fixes #20013

Description

  • Endpoints/EndpointSlice are internal resources created by k8s Services.
  • Kyverno UpdateRequest is an intermediate resource of the Kyverno controller
  • Kyverno ClusterPolicyReport/PolicyReport/EphemeralReport are results of policy evaluation and intermediary resources that do not need to be visualized in Argo.
  • TokenReview/SelfSubjectReview/LocalSubjectAccessReview/SelfSubjectAccessReview are temporary resources that should not be deployed with GitOps
  • APIService/Lease is a Kubernetes internal resource
  • CertificateSigningRequest/CertificateRequest are temporary resources created to create Certificate that should not be deployed with GitOps
  • Cilium resources seems like internal resources created by Cilium

Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault requested a review from a team as a code owner January 22, 2025 18:52
@agaudreault agaudreault added this to the v3.0 milestone Jan 22, 2025
Copy link

bunnyshell bot commented Jan 22, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault requested a review from a team as a code owner January 22, 2025 19:51
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.53%. Comparing base (b4a63ae) to head (9ec43e0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21635      +/-   ##
==========================================
- Coverage   55.59%   55.53%   -0.07%     
==========================================
  Files         340      340              
  Lines       57419    57419              
==========================================
- Hits        31924    31888      -36     
- Misses      22807    22829      +22     
- Partials     2688     2702      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault enabled auto-merge (squash) January 22, 2025 20:42
Copy link
Member

@reggie-k reggie-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @agaudreault!
Left 2 minor nit comments.

docs/operator-manual/upgrading/2.14-3.0.md Outdated Show resolved Hide resolved
docs/operator-manual/upgrading/2.14-3.0.md Outdated Show resolved Hide resolved
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, holding off merging in case you want to gather more feedback first

@agaudreault agaudreault marked this pull request as draft February 3, 2025 21:40
auto-merge was automatically disabled February 3, 2025 21:40

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore known Kubernetes internal resources by default with resource.exclusions
3 participants