Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sensor): disable leader election for jetstream eventbus #3240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mweibel
Copy link
Contributor

@mweibel mweibel commented Aug 15, 2024

Permit HA sensor when JetStream eventbus is used for sensors.

Checklist:

@mweibel
Copy link
Contributor Author

mweibel commented Oct 3, 2024

I see that #3303 has been created in the meanwhile, featuring an almost exact copy of this PR. @ryancurrah why did you open another PR with the same code?

anyhow, I don't mind which one is merged, as long as one is merged..

Copy link
Contributor

github-actions bot commented Dec 3, 2024

This Pull Request is stale because it has been open for 60 days with
no activity. It will be closed in 7 days if no further activity.

@github-actions github-actions bot added the stale label Dec 3, 2024
@mweibel
Copy link
Contributor Author

mweibel commented Dec 3, 2024

this is still open and not stale. @whynowy you commented on #3303 which copied this PR and got closed meanwhile. Did you get the chance to look at this again?

@mweibel
Copy link
Contributor Author

mweibel commented Dec 3, 2024

test failure does not seem related to my change.

/retest

@github-actions github-actions bot removed the stale label Dec 4, 2024
Copy link
Contributor

github-actions bot commented Feb 3, 2025

This Pull Request is stale because it has been open for 60 days with
no activity. It will be closed in 7 days if no further activity.

@github-actions github-actions bot added the stale label Feb 3, 2025
@mweibel mweibel force-pushed the feat-eventsource-jetstream-ha branch from 4e0896b to be16413 Compare February 3, 2025 11:47
@mweibel
Copy link
Contributor Author

mweibel commented Feb 3, 2025

still waiting for a review here.

@mweibel
Copy link
Contributor Author

mweibel commented Feb 3, 2025

kafka test fails, not related to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant