Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/errors is no longer maintained #7402

Closed
blkperl opened this issue Dec 14, 2021 · 2 comments · Fixed by #7440 or #13673
Closed

pkg/errors is no longer maintained #7402

blkperl opened this issue Dec 14, 2021 · 2 comments · Fixed by #7440 or #13673
Labels
go Pull requests that update Go dependencies good first issue Good for newcomers type/dependencies PRs and issues specific to updating dependencies type/tech-debt

Comments

@blkperl
Copy link
Contributor

blkperl commented Dec 14, 2021

Summary

pkg/errors is no longer maintained. See pkg/errors#245

Use Cases

We can replaces all calls to errors.Wrap/f with fmt.Errorf and removes the unneeded dependency on
github.com/pkg/errors since we don't support go 1.12 or lower. See microsoft/go-winio#227 for an example.

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
@blkperl blkperl added the type/feature Feature request label Dec 14, 2021
@blkperl blkperl added the good first issue Good for newcomers label Feb 3, 2022
@blkperl
Copy link
Contributor Author

blkperl commented Feb 3, 2022

This is being worked on in #7440

@alexec alexec added type/tech-debt and removed type/feature Feature request labels Feb 7, 2022
@alexec alexec mentioned this issue Feb 7, 2022
Merged
1 task
@stale

This comment was marked as resolved.

Sign in to view
@stale stale bot added the problem/stale This has not had a response in some time label Mar 2, 2022
@alexec alexec removed the problem/stale This has not had a response in some time label Mar 2, 2022
@jay-khatri jay-khatri mentioned this issue Jan 30, 2023
Closed
blkperl added a commit to blkperl/argo-workflows that referenced this issue Sep 27, 2024
@blkperl
refactor: drop pkg/errors as a dependency
2af1b96 
Fixes argoproj#7402

Signed-off-by: william.vanhevelingen <[email protected]>
@blkperl blkperl mentioned this issue Sep 27, 2024
Merged
@agilgur5 agilgur5 changed the title pkg/errors is no longer maintained pkg/errors is no longer maintained Sep 28, 2024
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Sep 28, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
go Pull requests that update Go dependencies good first issue Good for newcomers type/dependencies PRs and issues specific to updating dependencies type/tech-debt
Projects
None yet
Milestone
No milestone
3 participants
@blkperl @alexec @agilgur5