Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(deps): drop pkg/errors as a direct dependency #13673

Merged
merged 1 commit into from
Sep 28, 2024
Merged

refactor(deps): drop pkg/errors as a direct dependency #13673

merged 1 commit into from
Sep 28, 2024

Conversation

blkperl
Copy link
Contributor

@blkperl blkperl commented Sep 27, 2024 •
edited
Loading

Fixes #7402

This a follow up to #7440 where we missed one file.

Motivation

  • pkgs/errors is no longer maintained

Modifications

  • changed workflow/artifacts/azure/azure.go to use fmt instead of errors

Verification

E2E tests will verify

@blkperl blkperl marked this pull request as ready for review September 27, 2024 23:51
@agilgur5 agilgur5 changed the title refactor: drop pkg/errors as a dependency refactor: drop pkg/errors as a direct dependency Sep 28, 2024
@agilgur5 agilgur5 changed the title refactor: drop pkg/errors as a direct dependency refactor(deps): drop pkg/errors as a direct dependency Sep 28, 2024
@agilgur5
Copy link
Contributor

This a follow up to #7440 where we missed one file.

Huh it looks like the go.mod changed there too, so I'm guessing this line was added after or there was a merge conflict or something that restored it

@agilgur5
Copy link
Contributor

Looks like #9026 added it back, potentially because it used older code as a base

agilgur5
agilgur5 reviewed Sep 28, 2024
View reviewed changes
go.mod Show resolved Hide resolved
agilgur5
agilgur5 approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the one leftover line

@agilgur5 agilgur5 merged commit ef09d9f into argoproj:main Sep 28, 2024
30 checks passed
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies type/tech-debt labels Sep 28, 2024
@agilgur5 agilgur5 mentioned this pull request Sep 28, 2024
Merged
@blkperl blkperl deleted the fix_pkg_errors branch September 28, 2024 17:05
@blkperl blkperl mentioned this pull request Oct 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg/errors is no longer maintained
2 participants
@blkperl @agilgur5