Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): fix lint failures #13853

Merged
merged 1 commit into from
Nov 2, 2024
Merged

chore(tests): fix lint failures #13853

merged 1 commit into from
Nov 2, 2024

Commits on Nov 2, 2024

  1. chore(tests): fix lint failures

    Every PR has been failing the `make lint` checked with the following
    error since argoproj#12960 was merged:
    ```
     			assert.Equal(t, 1, len(status.Outputs.Parameters))
    			^
    Error: test/e2e/suspend_test.go:124:4: len: use assert.Len (testifylint)
    			assert.Equal(t, 1, len(status.Inputs.Parameters))
    			^
    make: *** [Makefile:466: lint] Error 1
    ```
    
    This is happening due to a conflict between that PR and
    argoproj#13467. The latter PR was
    merged on August 14th, but the latest CI run for the former
    (https://github.com/argoproj/argo-workflows/actions/runs/9191558853/job/25278229097)
    was on May 22nd.
    
    Signed-off-by: Mason Malone <[email protected]>
    MasonM committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    69f92ac View commit details
    Browse the repository at this point in the history