feat: set template display name in yaml #14077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MenD32 <[email protected]>
MenD32
requested review from
Joibel,
terrytangyuan and
sarabala1979
as code owners
MenD32
changed the title
MenD32
changed the title
Signed-off-by: MenD32 <[email protected]>
MenD32
force-pushed
the
feat/template-displayname
branch
from
b367fde to
000a881
Compare
Signed-off-by: MenD32 <[email protected]>
MenD32
force-pushed
the
feat/template-displayname
branch
6 times, most recently
from
c136f29 to
1193701
Compare
Signed-off-by: MenD32 <[email protected]>
MenD32
force-pushed
the
feat/template-displayname
branch
from
1193701 to
83db9ba
Compare
added 2 commits
January 14, 2025 15:26
Signed-off-by: MenD32 <[email protected]>
…rkflows into feat/template-displayname Signed-off-by: MenD32 <[email protected]>
|
Could you post some screen shots? |
shuangkun
reviewed
Jan 15, 2025
examples/loops-param-argument.yaml
Outdated
| @@ -34,6 +34,7 @@ spec: | |||
| withParam: "{{inputs.parameters.os-list}}" | |||
|
|
|||
| - name: cat-os-release | |||
| displayName: "os-{{inputs.parameters.image}}-{{inputs.parameters.tag}}" | |||
There was a problem hiding this comment.
Could we refer to kubeflow pipeline to implement it with annotations?
https://github.com/kubeflow/pipelines/pull/2459/files
There was a problem hiding this comment.
yeah sure
now looks like this:
annotations:
workflows.argoproj.io/display-name: "os-{{inputs.parameters.image}}-{{inputs.parameters.tag}}"
shuangkun
added
area/ui
area/looping
added 2 commits
January 15, 2025 21:05
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
MenD32
force-pushed
the
feat/template-displayname
branch
from
e362891 to
696a7a8
Compare
Signed-off-by: MenD32 <[email protected]>
|
This feature can be used more widely than loops, to add pretty names for any node? I think this should be documented in markdown properly, rather than just in an example for one feature (loops). The "Annotations" part of the feature feels obscure as it is - what does it actually do to my pods for the different template types? And then document the special annotation that you've added here. |
|
it can be used for any node, not specifically in loops, I'll add a new page in the docs to document this. |
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
|
is the docs CI broken? looks like its failing spellcheck on unchanged docs... |
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
Signed-off-by: MenD32 <[email protected]>
MenD32
force-pushed
the
feat/template-displayname
branch
2 times, most recently
from
34d1600 to
675d698
Compare
Signed-off-by: MenD32 <[email protected]>
MenD32
force-pushed
the
feat/template-displayname
branch
from
675d698 to
6fdef4d
Compare
Joibel
reviewed
Jan 27, 2025
Signed-off-by: MenD32 <[email protected]>
MenD32
force-pushed
the
feat/template-displayname
branch
2 times, most recently
from
e802a10 to
2dacf13
Compare
Signed-off-by: MenD32 <[email protected]>
MenD32
force-pushed
the
feat/template-displayname
branch
from
2dacf13 to
5951b1e
Compare
Joibel
approved these changes
Jan 27, 2025
alexec
pushed a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: MenD32 <[email protected]> Co-authored-by: MenD32 <[email protected]> Signed-off-by: Alex Collins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: set up custom names for displayName in template definition
suggested on #13886
Motivation
Customizable display names for workflow nodes in the Argo UI enhance usability by allowing users to assign intuitive, context-specific labels, improving workflow readability and navigation.
This is especially prevalent in loops.
Modifications
Added displayName field to template struct, allowing to override the default displayName.
Verification
e2e test - loops-param-argument.yaml