Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to stable #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeswr
Copy link

@jeswr jeswr commented Feb 11, 2024

Upgrades to use leanprover/lean4:stable.

target importTarget (pkg : Package) : FilePath := do
let oFile := pkg.oleanDir / ffiO
target importTarget (pkg : NPackage _package.name) : FilePath := do
let oFile := pkg.buildDir / ffiO
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% confident that buildDir is the best directory to be using here

let name := nameToStaticLib "ffi"
let job ← fetch <| pkg.target ``importTarget
buildStaticLib (pkg.libDir / name) #[job]
buildStaticLib (pkg.buildDir / name) #[job]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not 100% confident that buildDir is the best directory to be using here

@arthurpaulino
Copy link
Member

Sorry @jeswr, unfortunately I don't have the cycles to review/test these changes (#3 included). That would require further understanding of the stable API, which I'm unable to inspect at the moment.

I'll leave these PRs open for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants