feat: hotfix workflow #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| title: "${{ inputs.type == 'release' && 'Release' || 'Hotfix' }} ${{ inputs.version }}" | ||
| branch: "${{ inputs.type }}/${{ inputs.version }}" | ||
| commit-message: "${{ inputs.type == 'release' && 'feat' || 'fix' }}: bump version to ${{ inputs.version }}" |
There was a problem hiding this comment.
.github/workflows/tag-release.yml
Outdated
| tag_name: ${{ steps.get-version.outputs.version }} | ||
| target_commitish: ${{ startsWith(github.event.pull_request.head.ref, 'release/') && github.event.pull_request.head.ref || github.event.pull_request.base.ref }} |
There was a problem hiding this comment.
Shouldn't this be ${{ github.event.pull_request.base.ref }} in all cases? That is, if the base of the PR is dev, then the release is created from dev, and if the base is release/, then the release is created from release/.
tchataigner
force-pushed
the
feature/bugfix-workflow
branch
from
fc401c7 to
4837ee4
Compare
This was referenced Jun 18, 2024
Signed-off-by: Thomas Chataigner <[email protected]>
Signed-off-by: Thomas Chataigner <[email protected]>
Signed-off-by: Thomas Chataigner <[email protected]>
Signed-off-by: Thomas Chataigner <[email protected]>
Signed-off-by: Thomas Chataigner <[email protected]>
Co-authored-by: Samuel Burnham <[email protected]>
Signed-off-by: Thomas Chataigner <[email protected]>
* ci: Update release workflow * fix: Enforce `major.minor` version only for initial release * fix: Use full `major.minor.patch` for `Cargo.toml` and tag
tchataigner
force-pushed
the
feature/bugfix-workflow
branch
from
8601da5 to
522b39b
Compare
samuelburnham
approved these changes
Jun 18, 2024
storojs72
pushed a commit
that referenced
this pull request
Jun 18, 2024
* ci: release ci Signed-off-by: Thomas Chataigner <[email protected]> * ci: add release creation Signed-off-by: Thomas Chataigner <[email protected]> * ci: fix release files Signed-off-by: Thomas Chataigner <[email protected]> * ci: update based on review Signed-off-by: Thomas Chataigner <[email protected]> * ci: dry files & hotfix flow Signed-off-by: Thomas Chataigner <[email protected]> * Apply suggestions from code review Co-authored-by: Samuel Burnham <[email protected]> * ci: base for PR Signed-off-by: Thomas Chataigner <[email protected]> * ci: Update release workflow (#26) * ci: Update release workflow * fix: Enforce `major.minor` version only for initial release * fix: Use full `major.minor.patch` for `Cargo.toml` and tag --------- Signed-off-by: Thomas Chataigner <[email protected]> Co-authored-by: Samuel Burnham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR udpates the workflow files for release to also be used for a hotfix flow. The flow would work as follow:
bump-version-PRflow to create a new branch a PR to the desiredreleasebranchhotfixbranch to implement the needed fixesreleasebranchPart of #13