Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proper docker publish flow #219

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Conversation

tchataigner
Copy link
Contributor

@tchataigner tchataigner commented Sep 12, 2024

This PR updates our docker publish flow so that we can upload our images as package of the repository.

For now the image has to be run on top of the desired branch to use for the image publication and the tag for the image is a manual input.

The workflow could be upgraded later on to trigger on commit merge on release branches, and have manual trigger for :latest images on dev.

Successful run Aptos:

@tchataigner tchataigner force-pushed the feature/docker-publish-flow branch from 33a28cc to c91a475 Compare September 12, 2024 11:54
@tchataigner tchataigner marked this pull request as ready for review September 12, 2024 12:30
@tchataigner tchataigner force-pushed the feature/docker-publish-flow branch from 595659f to d6e62cd Compare September 12, 2024 13:56
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tchataigner tchataigner merged commit 4c62493 into dev Sep 12, 2024
8 checks passed
@tchataigner tchataigner deleted the feature/docker-publish-flow branch September 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants