test: revamp e2e benchmark to generate both snark and stark #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchataigner
force-pushed
the
feature/update-bench
branch
2 times, most recently
from
f98d65e to
89da258
Compare
Signed-off-by: Thomas Chataigner <[email protected]>
tchataigner
force-pushed
the
feature/update-bench
branch
from
89da258 to
85a0c95
Compare
wwared
previously approved these changes
Jun 19, 2024
Co-authored-by: wwared <[email protected]>
Because of the failing dependencies for the patches. But this PR fixes it. |
samuelburnham
approved these changes
Jun 19, 2024
wwared
approved these changes
Jun 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the
e2e.rsbenchmark in theaptos-lccrate so that it also runs the SNARK proof generation.The output is in the shape:
{ "epoch_change_proof": { "snark_proving_time": 441148, "stark_proving_time": 53353 }, "inclusion_proof": { "snark_proving_time": 423933, "stark_proving_time": 40474 } }With the time expressed in ms.
Also, update to the latest commit of:
sha2patch: sp1-patches/RustCrypto-hashes@1f22438tiny-keccakpatch: sp1-patches/tiny-keccak@bf0b28f