Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Improve merge_group and branch protection #317

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Conversation

samuelburnham
Copy link
Member

@samuelburnham samuelburnham commented Nov 1, 2024

  • Fixes cycle-count-regression comparison on merge_group
  • Removes redundant CI checks on push to dev, since they are already run on merge_group
  • Fixes default channel for bench.yml Zulip message
  • Adds a unified status check for branch protection rules called check-job-results, which will succeed if all other jobs in rust.yml succeed or are skipped (including matrix jobs). If any of them fail, then check-job-results will fail, blocking merge or dequeueing from the merge queue if it's added as a required status check in branch protection.

Successful runs:

@samuelburnham samuelburnham changed the title ci: merge group ci: Improve merge_group and branch protection Nov 1, 2024
@samuelburnham samuelburnham marked this pull request as ready for review November 1, 2024 17:50
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@huitseeker huitseeker added this pull request to the merge queue Nov 4, 2024
Merged via the queue into dev with commit 66a31e1 Nov 4, 2024
10 checks passed
@huitseeker huitseeker deleted the ci-merge-group branch November 4, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants