Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update bump-version-PR.yml #38

Merged
merged 2 commits into from
Jun 24, 2024
Merged

ci: Update bump-version-PR.yml #38

merged 2 commits into from
Jun 24, 2024

Conversation

samuelburnham
Copy link
Member

@samuelburnham samuelburnham commented Jun 21, 2024 •
edited
Loading

@samuelburnham samuelburnham enabled auto-merge (squash) June 21, 2024 20:07
tchataigner
tchataigner approved these changes Jun 22, 2024
View reviewed changes
Copy link
Contributor

@tchataigner tchataigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one NIT is that it could be great to stick to one way of referring to environment variables. Either ${{ env.MY_VAR }} or $MY_VAR.

huitseeker
huitseeker approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@samuelburnham samuelburnham merged commit 7f213e4 into dev Jun 24, 2024
3 checks passed
@tchataigner tchataigner deleted the ci-release branch July 26, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchataigner tchataigner tchataigner approved these changes

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelburnham @huitseeker @tchataigner