feat: LightClientSnapshot #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchataigner
force-pushed
the
feature/light-client-snapshot
branch
3 times, most recently
from
71caec4 to
e5349d6
Compare
Signed-off-by: Thomas Chataigner <[email protected]>
tchataigner
force-pushed
the
feature/light-client-snapshot
branch
from
e5349d6 to
fa39963
Compare
wwared
previously approved these changes
Jul 1, 2024
ethereum/core/src/types/block.rs
Outdated
|
|
||
| /// `BeaconBlockHeader` represents the header of a beacon block. | ||
| /// | ||
| /// From [the CL specifications](https://github.com/ethereum/consensus-specs/blob/v1.3.0/specs/phase0/beacon-chain.md#beaconblockheader). |
There was a problem hiding this comment.
tiny suggestion: It took me a second to realize "CL" means "consensus layer", we could get rid of this acronym
There was a problem hiding this comment.
Alright, let me rephrase !
Co-authored-by: wwared <[email protected]>
wwared
approved these changes
Jul 3, 2024
Merged
tchataigner
added a commit
that referenced
this pull request
Jul 30, 2024
* feat: LightClientSnapshot (#58) Signed-off-by: Thomas Chataigner <[email protected]> * Update ethereum/core/src/crypto/mod.rs Co-authored-by: wwared <[email protected]> * docs: fix misleading acronym --------- Signed-off-by: Thomas Chataigner <[email protected]> Co-authored-by: wwared <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement the
LightClientSnapshotdata structure in thelight-clientcrate.It depends on 3 main data structures implemented in
core:BeaconBlockHeader: Implementation based on https://github.com/ethereum/consensus-specs/blob/v1.3.0/specs/phase0/beacon-chain.md#beaconblockheaderSyncCommittee: Implementation based on https://github.com/ethereum/consensus-specs/blob/v1.3.0/specs/altair/beacon-chain.md#synccommitteePublicKey: The implementation takes part of the code already implemented for the Aptos LC, such as the compression trick at runtime. This might not be needed in the future but we'll remove it then. This also tackles part of Cryptographic primitives data structures #60.Closes #58