Feat(eos_cli_config_gen): Add BFD Slow-Timer Knob (#4718)

aristanetworks · Nov 13, 2024 · 5300bf6 · 5300bf6
1 parent 24a97d2
commit 5300bf6
Show file tree

Hide file tree

Showing 8 changed files with 38 additions and 2 deletions.
diff --git a/...llections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md b/...llections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
@@ -5336,6 +5336,10 @@ policy-map type pbr PM_PBR_BREAKOUT
 
 ### Router BFD
 
+| BFD Tuning |
+| ---------- |
+| Slow-Timer 5000 |
+
 #### Router BFD Singlehop Summary
 
 | Interval | Minimum RX | Multiplier |
@@ -5361,6 +5365,7 @@ policy-map type pbr PM_PBR_BREAKOUT
 router bfd
    interval 900 min-rx 900 multiplier 50 default
    multihop interval 300 min-rx 300 multiplier 3
+   slow-timer 5000
    local-address 192.168.255.1
    session stats snapshot interval 51
    !

diff --git a/ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg b/ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
@@ -3530,6 +3530,7 @@ peer-filter PF2
 router bfd
    interval 900 min-rx 900 multiplier 50 default
    multihop interval 300 min-rx 300 multiplier 3
+   slow-timer 5000
    local-address 192.168.255.1
    session stats snapshot interval 51
    !

diff --git a/...llections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/router-bfd.yml b/...llections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/router-bfd.yml
@@ -23,3 +23,4 @@ router_bfd:
     reflector:
       min_rx: 600
       local_discriminator: 155.1.3.1
+  slow_timer: 5000
diff --git a/ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-bfd.md b/ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-bfd.md
diff --git a/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-bfd.j2 b/python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-bfd.j2
@@ -7,6 +7,14 @@
 {% if router_bfd is arista.avd.defined %}
 
 ### Router BFD
+{%     if router_bfd.slow_timer is arista.avd.defined %}
+
+| BFD Tuning |
+| ---------- |
+{%         if router_bfd.slow_timer is arista.avd.defined %}
+| Slow-Timer {{ router_bfd.slow_timer }} |
+{%         endif %}
+{%     endif %}
 {%     if router_bfd.interval is arista.avd.defined and router_bfd.min_rx is arista.avd.defined and router_bfd.multiplier is arista.avd.defined  %}
 
 #### Router BFD Singlehop Summary

diff --git a/python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bfd.j2 b/python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bfd.j2
@@ -7,12 +7,15 @@
 {% if router_bfd is arista.avd.defined %}
 !
 router bfd
-{%     if router_bfd.interval is arista.avd.defined and router_bfd.min_rx is arista.avd.defined and router_bfd.multiplier is arista.avd.defined  %}
+{%     if router_bfd.interval is arista.avd.defined and router_bfd.min_rx is arista.avd.defined and router_bfd.multiplier is arista.avd.defined %}
    interval {{ router_bfd.interval }} min-rx {{ router_bfd.min_rx }} multiplier {{ router_bfd.multiplier }} default
 {%     endif %}
-{%     if router_bfd.multihop.interval is arista.avd.defined and router_bfd.multihop.min_rx is arista.avd.defined and router_bfd.multihop.multiplier is arista.avd.defined  %}
+{%     if router_bfd.multihop.interval is arista.avd.defined and router_bfd.multihop.min_rx is arista.avd.defined and router_bfd.multihop.multiplier is arista.avd.defined %}
    multihop interval {{ router_bfd.multihop.interval }} min-rx {{ router_bfd.multihop.min_rx }} multiplier {{ router_bfd.multihop.multiplier }}
 {%     endif %}
+{%     if router_bfd.slow_timer is arista.avd.defined %}
+   slow-timer {{ router_bfd.slow_timer }}
+{%     endif %}
 {%     if router_bfd.local_address is arista.avd.defined %}
    local-address {{ router_bfd.local_address }}
 {%     endif %}

diff --git a/python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml b/python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml
diff --git a/python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bfd.schema.yml b/python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bfd.schema.yml
@@ -81,3 +81,10 @@ keys:
               local_discriminator:
                 type: str
                 description: IPv4 address or 32 bit integer.
+      slow_timer:
+        description: Rate in milliseconds.
+        type: int
+        convert_types:
+          - str
+        min: 2000
+        max: 60000