Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for ipv4/ipv6 access group ingress default in system.control_plane #4710

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Add support for ingress in system.control_plane

s1-spine1(config-system-cp)#ip access-group ?
  WORD     Access list name
  ingress  Specify default CP ACL for inbound packets

s1-spine1(config-system-cp)#ipv6 access-group ?
  WORD     Access list name
  ingress  Specify default CP ACL for inbound packets

Related Issue(s)

Fixes #4467

Component(s) name

arista.avd.eos_cli_config_gen

How to test

CI

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4710
# Activate the virtual environment
source test-avd-pr-4710/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@ingress_1#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,ingress_1 --force
# Optional: Install AVD examples
cd test-avd-pr-4710
ansible-playbook arista.avd.install_examples

@ClausHolbechArista ClausHolbechArista requested a review from a team November 11, 2024 16:30
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Nov 11, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the ingress_1 branch 2 times, most recently from 0a36b5a to 8522c48 Compare November 12, 2024 09:50
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Nov 13, 2024

Copy link
Contributor

@alexeygorbunov alexeygorbunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 35f3688 into aristanetworks:devel Nov 13, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include ingress option in system.control_plane.ipv4/6_access_group data model
5 participants