Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(plugins): Verify pyavd extras again in verify_requirements #4720

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Nov 13, 2024

Change Summary

Check again the sub requirements for pyavd[ansible-collection]

Component(s) name

plugins

Proposed changes

Read the metadata if any extras is detected and parse the markers.
It works also when running from source

How to test

Just install the PR and run it from source (using molecule) with -v as well as from one of your env where you install normally pyavd from git

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4720
# Activate the virtual environment
source test-avd-pr-4720/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@verify-pyavd-extra-reqs#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,verify-pyavd-extra-reqs --force
# Optional: Install AVD examples
cd test-avd-pr-4720
ansible-playbook arista.avd.install_examples

@gmuloc gmuloc marked this pull request as ready for review November 13, 2024 10:48
@gmuloc gmuloc requested review from a team as code owners November 13, 2024 10:48
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Nov 13, 2024
Copy link

sonarcloud bot commented Nov 13, 2024

@gmuloc gmuloc added this to the v5.1.0-dev2 milestone Nov 13, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Tested:

  • When running from source in AVD repo
  • Installing from PR and example inventory

@carlbuchmann carlbuchmann merged commit 73b7ff7 into aristanetworks:devel Nov 13, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(plugins)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants