cgroup: fix various issues with compatibility with older bst spacetimes #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, failed systemd units are kept around for inspection, but this is not desirable for bst's own use-case, since `bst false` is a valid invocation that should not warrant its own persistence.
The none driver simply disables the cgroup handling of bst, which was the original behaviour. It is not recommended for typical use, but it has its worth in testing and maintaining backward-compatibility.
This helps running bst in older bst spacetimes, where the cgroup was left unconfigured, and setting up a child cgroup is simply impossible.
Snaipe
force-pushed
the
fix/cgroup-compat
branch
from
085c7ec
to
cf3f27c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not possible to use bst with older versions of bst due to the older spacetime leaving the cgroup unconfigured. This means that /sys/fs/cgroup is unusable to the inner/newer bst, which in turn promptly fails.