Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tty: stop spamming VEOF on raw terminals, and cleanly handle EOF #97

Merged
merged 2 commits into from
Jun 28, 2024
Merged

tty: stop spamming VEOF on raw terminals, and cleanly handle EOF #97

merged 2 commits into from
Jun 28, 2024

Commits on Jun 28, 2024

  1. tty: stop spamming VEOF on raw terminals 

    There is no point in sending VEOF on PTYs that aren't interpreting them.

Simply hanging up and letting the session get killed with SIGHUP is the right
thing to do.
    @Snaipe
    Snaipe committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    b9c81fb View commit details
    Browse the repository at this point in the history

  2. tty: cleanly handle EOF 

    The old code would loop forever trying to read 0 bytes and thinking that
the input fd was read-ready. This is normally not an issue, but because
we're emulating regular files as eventfds (since epoll won't support
them), things like bst --tty cat </dev/null would never terminate.
    @Snaipe
    Snaipe committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    39eb520 View commit details
    Browse the repository at this point in the history