Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route53 #25

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

Route53 #25

wants to merge 64 commits into from

Conversation

larskuhtz
Copy link
Contributor

Hi Aristid,

Please consider merging the Route53 branch into the master branch. I would recommend that you have a quick lock at the Route53 code in order to ensure that it meats the quality bar and the coding style of the project.

Thanks,
Lars

Lars Kuhtz added 30 commits April 21, 2012 10:06
…he Response

Additionally remove an outdated TODO
Lars Kuhtz added 20 commits July 12, 2012 21:25
--HG--
rename : Examples/Route53Examples.hs => Examples/Route53/Utils.hs
--HG--
rename : Examples/Route53/DynDNS.hs => Examples/Route53/R53DynDNS.hs
--HG--
rename : Examples/Route53/R53DynDNS.hs => Examples/Route53/r53-dyndns.hs
The fix includes porting all functions that returned IO (Attempt a) to
return MonadIO m => AttemptT m a.
@jberryman
Copy link

Is there a plan for a release on hackage that supports Route 53? Thanks!

@aristidb
Copy link
Owner

aristidb commented Jan 7, 2013

@jberryman There are a couple of things with this pull request that would need to be sorted out, so I don't think this can happen too soon.

The main problem right now, I think, is that this pull request introduces some additional dependencies which I don't want to put into the aws main package.

@larskuhtz
Copy link
Contributor Author

Hi,

Unfortunately I currently have no free cycles to work on the Route53 code
and resolve the compatibility and dependency issues, but I am happy to
accept patches. Feel free to make any changes that you think are adequate
and to remove any dependencies that are an issue for the integration with
the AWS code. Probably, the current Route53 code won't work with recent
versions of the AWS package. So this would need fixing, too.

Alternatively, the Route53 code could be put into Hackage as a separate
package, but this should be subject to the code working with recent versions
of AWS.

Cheers,
Lars

From: Aristid Breitkreuz [email protected]
Reply-To: aristidb/aws
<reply+i-5588302-cb3966c455835425c316c6c2ccf6a27aa0ceefad-1369810@reply.gith
ub.com>
Date: Monday, January 7, 2013 11:17 AM
To: aristidb/aws [email protected]
Cc: Lars Kuhtz [email protected]
Subject: Re: [aws] Route53 (#25)

@jberryman https://github.com/jberryman There are a couple of things with
this pull request that would need to be sorted out, so I don't think this
can happen too soon.

The main problem right now, I think, is that this pull request introduces
some additional dependencies which I don't want to put into the aws main
package.


Reply to this email directly or view it on GitHub
#25 (comment) .

@jberryman
Copy link

FWIW as a user I wouldn't mind seeing the package split up into many parts,
even to the level off having a separate package for stuff like signing API
calls. Thanks for the update and for your work on the package
On Jan 7, 2013 2:54 PM, "Lars Kuhtz" [email protected] wrote:

Hi,

Unfortunately I currently have no free cycles to work on the Route53 code
and resolve the compatibility and dependency issues, but I am happy to
accept patches. Feel free to make any changes that you think are adequate
and to remove any dependencies that are an issue for the integration with
the AWS code. Probably, the current Route53 code won't work with recent
versions of the AWS package. So this would need fixing, too.

Alternatively, the Route53 code could be put into Hackage as a separate
package, but this should be subject to the code working with recent
versions
of AWS.

Cheers,
Lars

From: Aristid Breitkreuz [email protected]
Reply-To: aristidb/aws

<reply+i-5588302-cb3966c455835425c316c6c2ccf6a27aa0ceefad-1369810@reply.gith
ub.com>
Date: Monday, January 7, 2013 11:17 AM
To: aristidb/aws [email protected]
Cc: Lars Kuhtz [email protected]
Subject: Re: [aws] Route53 (#25)

@jberryman https://github.com/jberryman There are a couple of things
with
this pull request that would need to be sorted out, so I don't think this
can happen too soon.

The main problem right now, I think, is that this pull request introduces
some additional dependencies which I don't want to put into the aws main
package.


Reply to this email directly or view it on GitHub
#25 (comment) .


Reply to this email directly or view it on GitHubhttps://github.com//pull/25#issuecomment-11968332.

@dterei
Copy link

dterei commented Jul 15, 2013

Has there been any update on this?

@sseveran
Copy link

@dterei I have pushed a version that merges these changes and builds on the most recent version in our repo (https://github.com/alphaHeavy/aws/tree/Route53-test). I may work on breaking the xml-hamlet dependency.

@larskuhtz
Copy link
Contributor Author

Hi Steve,

Thanks for updating the code. Would it be possible do the merge such
that the history of the Route53 code is preserved? That would make it
easier to track and review changes.

Thanks,
Lars

On 7/18/13 9:33 PM, Steve Severance wrote:

@dterei https://github.com/dterei I have pushed a version that
merges these changes and builds on the most recent version in our repo
(https://github.com/alphaHeavy/aws/tree/Route53-test). I may work on
breaking the xml-hamlet dependency.


Reply to this email directly or view it on GitHub
#25 (comment).

@dterei
Copy link

dterei commented Jul 19, 2013

@aristidb Could you list what you'd like changed for this to be merged in please? Is it simply removing the xml-hamlet dependency or is there more?

@aristidb
Copy link
Owner

Well that's what I noticed first, I'd need to take a closer look to list
more things.
Am 19.07.2013 11:44 schrieb "David Terei" [email protected]:

@aristidb https://github.com/aristidb Could you list what you'd like
changed for this to be merged in please? Is it simply removing the
xml-hamlet dependency or is there more?


Reply to this email directly or view it on GitHubhttps://github.com//pull/25#issuecomment-21240755
.

@dterei
Copy link

dterei commented Jul 6, 2014

For anyone looking for this code, we created an independent route53 package from this PR a while back and actively maintain it as we rely on it in production. It's essentially the code from this PR with some bug fixes and kept up-to-date for latest GHC / Hackage.

https://github.com/memcachier/aws-route53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants