Rgb support #863
Open
Rgb support #863
+234
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchoisel
reviewed
Jan 3, 2025
arjunrajlab
force-pushed
the
rgb-support
branch
from
ac69962 to
7bd9be1
Compare
If a file had channels, then those would get improperly split up. Also, we failed to preserve the pass-through behavior for e.g. ND2 files. This fix reverts to the old behavior if not an RGB file, and will explicitly specify channels for RGB files.
|
@pchoisel This PR actually had a major bug in it that took some time to identify and fix (it is pure luck I didn't merge it already!). I think I fixed it, but I think I might deploy in house for a while first and then merge if there are no complaints. |
|
LGTM, you can merge when you need to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for RGB images by parsing bands.
In the process, also refactored the generated multi-source JSON to be more explicit about sources for each frame. This was done to avoid a bug in the way large_image was previously parsing things in the non-composited case @manthey. Problem is solved for our scenario, so all good, but I can try and reproduce the bug if you are curious.