Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Driver を統一的に c2a-core で扱えるようにし，CDS の tlm と，テレメ不通関連 Cmd を追加 #270

Merged
merged 12 commits into from
Jan 5, 2024
Merged

Component Driver を統一的に c2a-core で扱えるようにし，CDS の tlm と，テレメ不通関連 Cmd を追加 #270

merged 12 commits into from
Jan 5, 2024

Conversation

meltingrabbit
Copy link
Member

@meltingrabbit meltingrabbit commented Dec 31, 2023 •
edited
Loading

概要

Component Driver を統一的に c2a-core で扱えるようにし，CDS の tlm と，テレメ不通関連 Cmd を追加

Issue

詳細

CDRV の定義を user で設定することで，c2a core 側の App やコードで， CDRV を統一的に扱えるようにした．
それに伴い，各 CDRV の CDS のメンバをテレメで落とせるようにした．
さらに，テレメ不通関連の設定，有効化をできるようにした

検証結果

CI が通ればOK

補足

@meltingrabbit meltingrabbit added enhancement New feature or request priority::medium priority medium labels Dec 31, 2023
@meltingrabbit meltingrabbit self-assigned this Dec 31, 2023
@meltingrabbit meltingrabbit changed the base branch from main to feature/rename_component_driver_super December 31, 2023 18:14
@meltingrabbit meltingrabbit mentioned this pull request Jan 1, 2024
Merged
1 task
@meltingrabbit meltingrabbit force-pushed the feature/component_driver branch from d91c5c9 to d43e657 Compare January 1, 2024 05:03
@meltingrabbit meltingrabbit changed the base branch from feature/rename_component_driver_super to feature/cleanup-driversuper January 1, 2024 05:03
@meltingrabbit meltingrabbit changed the title WIP Component Driver を統一的に c2a-core で扱えるようにし，CDS の tlm と，テレメ不通関連 Cmd を追加 Jan 1, 2024
@meltingrabbit
Copy link
Member Author

@ToshiAki64 @hender14 レビューお願いします

@meltingrabbit meltingrabbit mentioned this pull request Jan 1, 2024
Merged
1 task
@meltingrabbit meltingrabbit force-pushed the feature/cleanup-driversuper branch from a4fa33b to 44a5cb4 Compare January 4, 2024 03:36
@meltingrabbit meltingrabbit force-pushed the feature/component_driver branch from 0212d14 to fdf0c26 Compare January 4, 2024 03:37
@meltingrabbit meltingrabbit force-pushed the feature/cleanup-driversuper branch from 44a5cb4 to 63afee6 Compare January 4, 2024 09:02
@meltingrabbit meltingrabbit force-pushed the feature/component_driver branch from fdf0c26 to d450ccb Compare January 4, 2024 09:02
ToshiAki64
ToshiAki64 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@ToshiAki64 ToshiAki64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実装は、いいと思います。
core update時に、既存の処理がある user は、そのままでいいか。
バサッと、core の処理に切り替えるかなどの指針がどこかのドキュメントにあるといいかと。

@meltingrabbit meltingrabbit force-pushed the feature/cleanup-driversuper branch from 63afee6 to 132a9c9 Compare January 5, 2024 06:03
Base automatically changed from feature/cleanup-driversuper to main January 5, 2024 06:06
@meltingrabbit meltingrabbit force-pushed the feature/component_driver branch from d450ccb to 5a6d9f0 Compare January 5, 2024 06:06
@meltingrabbit meltingrabbit merged commit 3add787 into main Jan 5, 2024
37 checks passed
@meltingrabbit meltingrabbit deleted the feature/component_driver branch January 5, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToshiAki64 ToshiAki64 ToshiAki64 approved these changes

@hender14 hender14 Awaiting requested review from hender14

Assignees

@meltingrabbit meltingrabbit

Labels
enhancement New feature or request priority::medium priority medium
Projects
C2A public
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltingrabbit @ToshiAki64