Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force set home crate to 0.5.9 #404

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

sksat
Copy link
Member

@sksat sksat commented Jan 8, 2025

  • Fixes pytest と clippy の CI がコケてる #401
  • pytest と clippy の CI がコケてる #401 (comment)home crate が patch update で MSRV を上げたことによるもの
    • その上で、examples/mobc などでは lockfile を固定していなかったため、dependencies を lock してビルドすることができなかった
    • また、できたところで clippy などでは lib crate もビルド対象となるので無意味
  • どうにもならないが、Rust 1.76.0 ~ 1.81.0 の間には 1.79.0 があり、これは cargo: prevent dashes in lib.name rust-lang/cargo#12783 を踏み抜く
    • なので、無理矢理 Rust 1.81.0 にジャンプするのは些か乱暴すぎる
  • そのため、home crate のバージョンを MSRV が上がる前のものに patch version まで明示的に固定し、Rust 1.76.0 でもビルドできるようにする
  • patch update で MSRV を上げるな
    • major = 0 とはいえども!!!

@sksat sksat self-assigned this Jan 8, 2025
@sksat sksat changed the title Force set home crate to 0.5.9 to build Force set home crate to 0.5.9 Jan 8, 2025
@sksat sksat force-pushed the hotfix/force-set-home-crate-version-for-msrv branch from b1c6aa7 to c29131f Compare January 8, 2025 09:26
@sksat sksat requested review from KOBA789 and ymgyt January 8, 2025 09:30
Copy link
Member

@ymgyt ymgyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch で MSRV あがるのつらいですね

@sksat sksat merged commit c61b74b into main Jan 8, 2025
37 checks passed
@sksat sksat deleted the hotfix/force-set-home-crate-version-for-msrv branch January 8, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

pytest と clippy の CI がコケてる
2 participants